On 12/30/21, 3:52 AM, "Maxim Orlov" <orlovmg@gmail.com> wrote:
> I did check the patch too and found it to be ok. Check and check-world are passed.
> Overall idea seems to be good in my opinion, but I'm not sure where is the optimal place to put the pre-allocation.
>
> On Thu, Dec 30, 2021 at 2:46 PM Pavel Borisov <pashkin.elfe@gmail.com> wrote:
>> I've checked the patch v7. It applies cleanly, code is good, check-world tests passed without problems.
>> I think it's ok to use checkpointer for this and the overall patch can be committed. But the seen performance gain
makesme think again before adding this feature. I did tests myself a couple of months ago and got similar results.
>> Really don't know whether is it worth the effort.
Thank you both for your review.
Nathan