Re: [PATCH] Missing dep on Catalog.pm in meson rules

On Fri Jun 2, 2023 at 8:00 AM CDT, Andres Freund wrote:
> Hi,
>
> On 2023-06-01 23:06:04 -0500, Tristan Partin wrote:
> > In our case, we should add the ^line to src/backend/catalog/meson.build.
>
> src/backend is only reached well after src/include, due to needing
> dependencies on files generated in src/include.

I was worried about this :(.

> I wonder if we instead could just make perl output the files it loads and
> handle dependencies automatically that way? But that's more work, so it's
> probably the right thing to go for the manual path for now.

I am not familar with Perl enough (at all haha) to know if that is
possible. I don't know exactly what these Perl files do, but perhaps it
might make sense to have some global lookup table that is setup near the
beginning of the script.

perl_files = {
  'Catalog.pm': files('path/to/Catalog.pm'),
  ...
}

Otherwise, manual as it is in the original patch seems like an alright
compromise for now.

--
Tristan Partin
Neon (https://neon.tech)