Re: [PATCH] Missing dep on Catalog.pm in meson rules

Hi,

On 2023-06-02 08:10:43 -0500, Tristan Partin wrote:
> > I wonder if we instead could just make perl output the files it loads and
> > handle dependencies automatically that way? But that's more work, so it's
> > probably the right thing to go for the manual path for now.
> 
> I am not familar with Perl enough (at all haha) to know if that is
> possible. I don't know exactly what these Perl files do, but perhaps it
> might make sense to have some global lookup table that is setup near the
> beginning of the script.

It'd be nice to have something more general - there are other perl modules we
load, e.g.
./src/backend/catalog/Catalog.pm
./src/backend/utils/mb/Unicode/convutils.pm
./src/tools/PerfectHash.pm


> perl_files = {
>   'Catalog.pm': files('path/to/Catalog.pm'),
>   ...
> }

I think you got it, but just to make sure: I was thinking of generating a
depfile from within perl. Something like what you propose doesn't quite seems
like a sufficient improvement.


> Otherwise, manual as it is in the original patch seems like an alright
> compromise for now.

Yea. I'm working on a more complete version, also dealing with dependencies on
PerfectHash.pm.

Greetings,

Andres Freund