RE: Psql meta-command conninfo+
От | Maiquel Grassi |
---|---|
Тема | RE: Psql meta-command conninfo+ |
Дата | |
Msg-id | CP8P284MB2496063E9719829163E02ADAEC392@CP8P284MB2496.BRAP284.PROD.OUTLOOK.COM обсуждение исходный текст |
Ответ на | Re: Psql meta-command conninfo+ ("Imseih (AWS), Sami" <simseih@amazon.com>) |
Ответы |
Re: Psql meta-command conninfo+
(Alvaro Herrera <alvherre@alvh.no-ip.org>)
Re: Psql meta-command conninfo+ ("Imseih (AWS), Sami" <simseih@amazon.com>) |
Список | pgsql-hackers |
> 1/ The output should be reorganized to show the fields that are part of “conninfo” first.
> With regards to the documentation. I think it's a good idea that every field has an
> description. However, I have some comments:
> 1/ For the description of the conninfo command, what about simplifying like below?
> "Outputs a string displaying information about the current database connection. When + is appended, more details about the connection are displayed in table format:"
> 2/ I don't think the descriptions need to start with "Displays". It is very repetitive.
> 3/ For the "Socket Directory" description, this could be NULL if the host was not specified.
> What about the below?
> "The socket directory of the connection. NULL if the host or hostaddr are specified for the connection"
> 4/ For most of the fields, they are just the output of a function, such as "pg_catalog.system_user()". What about the docs simply
> link to the documentation of the function. This way we are not copying descriptions and have to be concerned if the description
> of the function changes in the future.
> 5/ "true" and "false", do not need double quotes. This is not the convention used in other places docs.
-----//-----
Hi Sami!
(v22)
I did everything you mentioned earlier, that is, I followed all your suggestions. However,
I didn't complete item 4. I'm not sure, but I believe that linking it to the documentation
could confuse the user a bit. I chose to keep the descriptions as they were. However, if
you have any ideas on how we could outline it, let me know and perhaps we can
implement it.
Thank you so much!
Exemples:
[postgres@localhost bin]$ ./psql -x -p 5000 -h 127.0.0.1
Regards,
Maiquel Grassi.
Вложения
В списке pgsql-hackers по дате отправления:
Предыдущее
От: Kartyshov IvanДата:
Сообщение: Re: [HACKERS] make async slave to wait for lsn to be replayed