Re: [HACKERS] [PATCH]make pg_rewind to not copy useless WAL files

Поиск
Список
Период
Сортировка
От Alexander Korotkov
Тема Re: [HACKERS] [PATCH]make pg_rewind to not copy useless WAL files
Дата
Msg-id CAPpHfdvcppWpX9Y0VV5VrqJSVYQQEz=KW3CFZS2cgjfvPxcV4Q@mail.gmail.com
обсуждение исходный текст
Ответ на [HACKERS] [PATCH]make pg_rewind to not copy useless WAL files  (chenhj <chjischj@163.com>)
Ответы Re: [HACKERS] [PATCH]make pg_rewind to not copy useless WAL files  (Michael Paquier <michael.paquier@gmail.com>)
Список pgsql-hackers
Дерево обсуждения
Hi!

On Sat, Sep 16, 2017 at 5:56 PM, chenhj <chjischj@163.com> wrote:
This patch optimizes the above mentioned issues, as follows:
1. In the target data directory, do not delete the WAL files before the divergence.
2. When copying files from the source server, do not copy the WAL files before the divergence and the WAL files after the current WAL insert localtion.

Looks like cool optimization for me.  Please, add this patch to the next commitfest.
Do you think this patch should modify pg_rewind tap tests too?  It would be nice to make WAL files fetching more covered by tap tests.  In particular, new tests may generate more WAL files and make sure that pg_rewind fetches only required files among them.

------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company 

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: [HACKERS] Sync BEFORE STATEMENT trigger behavior with AFTER STATEMENT
Следующее
От: Andres Freund
Дата:
Сообщение: [HACKERS] Re: [COMMITTERS] pgsql: Perform only one ReadControlFile() duringstartup.