[HACKERS] Re: [COMMITTERS] pgsql: Perform only one ReadControlFile() duringstartup.

Поиск
Список
Период
Сортировка
От Andres Freund
Тема [HACKERS] Re: [COMMITTERS] pgsql: Perform only one ReadControlFile() duringstartup.
Дата
Msg-id 20170916182634.blb7upixw7hosdhu@alap3.anarazel.de
обсуждение исходный текст
Ответ на Re: [HACKERS] [COMMITTERS] pgsql: Perform only one ReadControlFile() during startup.  (Tom Lane <tgl@sss.pgh.pa.us>)
Ответы Re: [HACKERS] Re: [COMMITTERS] pgsql: Perform only one ReadControlFile() during startup.  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-hackers
Hi,

On 2017-09-16 10:32:29 -0400, Tom Lane wrote:
> It's dying at "pfree(localControlFile)".  localControlFile seems to
> be pointing at a region of memory that's entirely zeroes; certainly
> the data that it just moved into shared memory is all zeroes.
> It looks like someone didn't think hard enough about when to reset
> ControlFile to null.

Yep. Just adding a LocalProcessControlFile() reset_shared() works after
removing the assert from LocalProcessControlFile().  That's not what I'm
proposing, just confirming that that's the issue.

Looking into it.

Greetings,

Andres Freund


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Alexander Korotkov
Дата:
Сообщение: Re: [HACKERS] [PATCH]make pg_rewind to not copy useless WAL files
Следующее
От: Tom Lane
Дата:
Сообщение: Re: [HACKERS] Re: [COMMITTERS] pgsql: Perform only one ReadControlFile() during startup.