Re: Incorrect file reference in comment in procarray.c

Поиск
Список
Период
Сортировка
От Etsuro Fujita
Тема Re: Incorrect file reference in comment in procarray.c
Дата
Msg-id CAPmGK17xBNsstecZ91c4=0v83dWRs+ip2_qjE_rUQU2LBDx=HQ@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Incorrect file reference in comment in procarray.c  (Daniel Gustafsson <daniel@yesql.se>)
Ответы Re: Incorrect file reference in comment in procarray.c  (Etsuro Fujita <etsuro.fujita@gmail.com>)
Список pgsql-hackers
On Thu, Nov 2, 2023 at 10:20 PM Daniel Gustafsson <daniel@yesql.se> wrote:
> > On 2 Nov 2023, at 13:40, Etsuro Fujita <etsuro.fujita@gmail.com> wrote:
> > Attached is a small patch for that: s/heapam_visibility.c/snapmgr.c/.
>
> No objections to the patch, the change is correct.  However, with git grep and
> ctags and other ways of discovery I wonder if we're not better off avoiding
> such references to filenames which are prone to going stale (and do from time
> to time).

Agreed.  As XidInMVCCSnapshot() is an extern function, such a tool
would allow the reader to easily find the source file that contains
the definition of that function.

Thanks for the comment!

Best regards,
Etsuro Fujita



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Jelte Fennema-Nio
Дата:
Сообщение: Re: Report search_path value back to the client.
Следующее
От: John Naylor
Дата:
Сообщение: Re: Pre-proposal: unicode normalized text