Re: BEFORE UPDATE trigger on postgres_fdw table not work

Поиск
Список
Период
Сортировка
От Etsuro Fujita
Тема Re: BEFORE UPDATE trigger on postgres_fdw table not work
Дата
Msg-id CAPmGK16X4tt=S-J2gkVRZsH=Cz9AV0XRuZU2xzwx3Wj0_ET6Hg@mail.gmail.com
обсуждение исходный текст
Ответ на Re: BEFORE UPDATE trigger on postgres_fdw table not work  (Amit Langote <amitlangote09@gmail.com>)
Список pgsql-hackers
Amit-san,

On Wed, Jun 12, 2019 at 3:33 PM Amit Langote <amitlangote09@gmail.com> wrote:
> On Wed, Jun 12, 2019 at 3:14 PM Etsuro Fujita <etsuro.fujita@gmail.com> wrote:
> > * Reworded the comments a bit in postgresPlanFoereignModify the
> > original patch modified
>
> +     * statement, and for UPDATE if BEFORE ROW UPDATE triggers since those
> +     * triggers might change values for non-target columns, in which case we
>
> First line seems to be missing a word or two.  Maybe:
>
> +     * statement, and for UPDATE if there are BEFORE ROW UPDATE triggers,
> +     * since those triggers might change values for non-target columns, in

Actually, I omitted such words to shorten the comment, but I think
this improves the readability, so I'll update the comment that way.

Thanks for the review!

Best regards,
Etsuro Fujita



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Masahiko Sawada
Дата:
Сообщение: Re: [PATCH] Speedup truncates of relation forks
Следующее
От: Noah Misch
Дата:
Сообщение: Re: fix psql \conninfo & \connect when using hostaddr