Re: [Proposal] Level4 Warnings show many shadow vars

Поиск
Список
Период
Сортировка
От John W Higgins
Тема Re: [Proposal] Level4 Warnings show many shadow vars
Дата
Msg-id CAPhAwGzJpwpnvj_D8VTecGsog85=R1tOeMHJEMtvRFxR84ssbw@mail.gmail.com
обсуждение исходный текст
Ответ на RE: [Proposal] Level4 Warnings show many shadow vars  (Ranier Vilela <ranier_gyn@hotmail.com>)
Ответы RE: [Proposal] Level4 Warnings show many shadow vars  (Ranier Vilela <ranier_gyn@hotmail.com>)
Список pgsql-hackers


On Tue, Dec 10, 2019 at 5:21 AM Ranier Vilela <ranier_gyn@hotmail.com> wrote:
New version the global patch, with the considerations.
Unfortunately WalReceiverConn cannot be used because it is currently the typedef name for the structure.
I switched to WalReceiverConnection, it was long but it looks good.
RedoRecPtr proper name has no consensus yet, so it was still lastRedoRecPtr.


For someone that expounds consistency - this patch is the furthest thing from it.

In some places names are randomly changed to have an underscore (authmethodlocal to authmethod_local with the obvious inconsistency as well) - in some places names are changed to remove underscores (stop_t to stopt). Some places random letters are added (checkPoint to xcheckPoint) some places perfectly good names are truncated (conf_file to file).

Random places remove perfectly good prefixes and replace with single letters (numTables to nTables)

Random places switch from lower case names to upper case names (sentPtr to WalSentPtr) most places leave lower case names (days to ndays).

Please at least be consistent within the patch itself.....

John W Higgins

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: Re: Windows buildfarm members vs. new async-notify isolation test
Следующее
От: Tom Lane
Дата:
Сообщение: Re: Unicode normalization test broken output