Re: Improve join_search_one_level readibilty (one line change)

Поиск
Список
Период
Сортировка
От Julien Rouhaud
Тема Re: Improve join_search_one_level readibilty (one line change)
Дата
Msg-id CAOBaU_YTCo6F2kkhJy8jWmw--iDYHTEWeENunyu0Bc27VfO_KQ@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Improve join_search_one_level readibilty (one line change)  (謝東霖 <douenergy@gmail.com>)
Ответы Re: Improve join_search_one_level readibilty (one line change)  (Tom Lane <tgl@sss.pgh.pa.us>)
Re: Improve join_search_one_level readibilty (one line change)  (謝東霖 <douenergy@gmail.com>)
Список pgsql-hackers
Дерево обсуждения
On Tue, 6 Jun 2023, 16:18 謝東霖, <douenergy@gmail.com> wrote:
Thank you to Julien Rouhaud and Tender Wang for the reviews.

Julien's detailed guide has proven to be incredibly helpful, and I am
truly grateful for it.
Thank you so much for providing such valuable guidance!

I have initiated a new commitfest:
https://commitfest.postgresql.org/43/4346/

Furthermore, I have attached a patch that improves the code by moving
the initialization of "other_rels_list" outside the if branching.

I'm glad I could help! Thanks for creating the cf entry. Note however that the cfbot ignores files with a .txt extension (I don't think it's documented but it will mostly handle files with diff, patch, gz(ip), tar extensions IIRC, processing them as needed depending on the extension), so you should send v2 again with a supported extension, otherwise the cfbot will keep testing your original patch.

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Richard Guo
Дата:
Сообщение: Re: Assert failure of the cross-check for nullingrels
Следующее
От: Tom Lane
Дата:
Сообщение: Re: Improve join_search_one_level readibilty (one line change)