Re: POC: Extension for adding distributed tracing - pg_tracing

Поиск
Список
Период
Сортировка
От Anthonin Bonnefoy
Тема Re: POC: Extension for adding distributed tracing - pg_tracing
Дата
Msg-id CAO6_XqoVRLi+cy5x=ST9n1V823YFqXQkCBbpbRaGY2vqf4MLBw@mail.gmail.com
обсуждение исходный текст
Ответ на Re: POC: Extension for adding distributed tracing - pg_tracing  (Nikita Malakhov <hukutoc@gmail.com>)
Ответы Re: POC: Extension for adding distributed tracing - pg_tracing  (Nikita Malakhov <hukutoc@gmail.com>)
Список pgsql-hackers
Hi, 

> I'd keep Autotools build up to date
Definitely. The patch is still in a rough state and updating Autotools fell through the cracks.

> I'm currently playing with the patch and
> reviewing sources, if you need any cooperation - please let us know.
The goal for me was to get validation on the design and to check if there was anything that would be a blocker before commiting more time on the project.

There are already several things I was planning on improving:
- The parse span is something I've added recently. I've realised that I could rely on the stmtStartTimestamp to get the time spent in parsing in the post parse hook so the code around this is still rough.
- There are probably race conditions on the reads and writes of the query file that need to be fixed
- I'm using the same Span structure for everything while Executor spans only need a small subset which is a bit wasteful. I've tried to use two different shared buffers (base spans and spans with counters) but it was making things more confusing.
- Finish commenting code and start writing the doc

So any comments, missing features and reviews on the current state of the project is welcome.

Regards,
Anthonin

On Fri, Jul 28, 2023 at 9:35 AM Nikita Malakhov <hukutoc@gmail.com> wrote:
Hi,

I'd keep Autotools build up to date, because Meson is very limited in terms of not very
up-to-date OS versions. Anyway, it's OK now. I'm currently playing with the patch and
reviewing sources, if you need any cooperation - please let us know. I'm +1 for committing
this patch after review.

--
Regards,
Nikita Malakhov
Postgres Professional
The Russian Postgres Company

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Noah Misch
Дата:
Сообщение: Re: Postgres v15 windows bincheck regression test failures
Следующее
От: vignesh C
Дата:
Сообщение: Re: [PoC] pg_upgrade: allow to upgrade publisher node