Re: [pgAdmin4][Patch] - SonarQube Fixes

Поиск
Список
Период
Сортировка
От Akshay Joshi
Тема Re: [pgAdmin4][Patch] - SonarQube Fixes
Дата
Msg-id CANxoLDf93wWrt8W94wVhtz1mzFJJe2Hb8UNDPmL+maxwnpNcrQ@mail.gmail.com
обсуждение исходный текст
Ответ на [pgAdmin4][Patch] - SonarQube Fixes  (Khushboo Vashi <khushboo.vashi@enterprisedb.com>)
Ответы Re: [pgAdmin4][Patch] - SonarQube Fixes
Список pgadmin-hackers
Дерево обсуждения
Hi Khushboo

As per offline discussion, multiple developers declaring the constant for the same string and error messages. To avoid that only one developer should work on this task.
Suggestions:
  • We should have a common class for Constants (which are not module specific).
  • For module specific constants we should not declare them as Global variables if possible declare them as the Class variable.
  • For common error messages(if any) we can define functions in PGChildNodeView.
Please incorporate the changes send by Yogesh.   

On Mon, Aug 3, 2020 at 1:36 PM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,

Please find the attached patch to fix the sonarqube code smells having the rule "String literals should not be duplicated".

Thanks,
Khushboo


--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Sr. Software Architect
EDB Postgres
Mobile: +91 976-788-8246

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Yogesh Mahajan
Дата:
Сообщение: Re: [pgAdmin4][Patch] - SonarQube Issues - 12 (String literals should not be duplicated)
Следующее
От: Akshay Joshi
Дата:
Сообщение: pgAdmin 4 commit: Ensure that the Dictionaries drop-down shows all the