Re: [pgAdmin4][Patch] - SonarQube Issues - 12 (String literals should not be duplicated)

Поиск
Список
Период
Сортировка
От Yogesh Mahajan
Тема Re: [pgAdmin4][Patch] - SonarQube Issues - 12 (String literals should not be duplicated)
Дата
Msg-id CAMa=N=MW9skJiVY=EZa+Px+L3Ti_gcOgKJz4O==AF-UPaUsvPQ@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [pgAdmin4][Patch] - SonarQube Issues - 12 (String literals should not be duplicated)  (Akshay Joshi <akshay.joshi@enterprisedb.com>)
Список pgadmin-hackers
Дерево обсуждения
Hello,

Please find the attached patch - 


Thanks,
Yogesh Mahajan
QA - Team
EnterpriseDB Corporation

Phone: +91-9741705709


On Mon, Aug 3, 2020 at 12:56 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Yogesh

Instead of declaring global variables, I would suggest declaring them as a class variable (constants). Make the changes and resend the patch

On Mon, Aug 3, 2020 at 10:40 AM Yogesh Mahajan <yogesh.mahajan@enterprisedb.com> wrote:
Hi,

Please find patch which fixes 15+ issues related to rule - 
1.String literals should not be duplicated

Thanks,
Yogesh Mahajan
QA - Team
EnterpriseDB Corporation

Phone: +91-9741705709


--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Sr. Software Architect
EDB Postgres
Mobile: +91 976-788-8246

Вложения

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Aditya Toshniwal
Дата:
Сообщение: Re: WIP: SQL Formatter
Следующее
От: Akshay Joshi
Дата:
Сообщение: Re: [pgAdmin4][Patch] - SonarQube Fixes