I have removed the check like "if (i > 0 || i ==0)" from many places except one. I have tried to fix compiler warnings either by modifying the logic or putting some other checks. Attached is the modified patch, please review it.
wxGetSingleChoiceIndex returns integer not "unsigned integer"
And, this syntax is definitely wrong in any case for unsigned integers
Fixed the above by changing the data type from "unsigned int" to "int", but for the other cases in the patch where I have applied the logic
like if (i > 0 || i==0) to fix compiler warnings, we have already discussed the same solution on Friday.
Attached is the modified patch.
What did you discuss on Friday?
To fix compiler warnings we have to modify the condition in such a way that it will work. So we talked about modifying the condition like "((i > 0 || i ==0) && i != (size_t)-1)".