Re: [pgAdmin][RM4421] Inno setup script version compare fix

Поиск
Список
Период
Сортировка
От Akshay Joshi
Тема Re: [pgAdmin][RM4421] Inno setup script version compare fix
Дата
Msg-id CANxoLDdjtQK1sqmAhE4JsjdiM_5rvZnF31Po8NeDfGbmWyA8Aw@mail.gmail.com
обсуждение исходный текст
Ответ на [pgAdmin][RM4421] Inno setup script version compare fix  (Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>)
Ответы Re: [pgAdmin][RM4421] Inno setup script version compare fix  (Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>)
Список pgadmin-hackers
Дерево обсуждения
Hi Aditya 

I have asked Paresh to review the patch, he has given some review comments. Please fix those and the updated patch asap.  

On Tue, Jul 2, 2019 at 1:38 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch to fix a potential issue where version compare while upgrading will be incorrect. Currently, it is comparing strings. So while comparing '4.9' and '4.10' it will consider '4.9' as greater.
The patch will convert the values to float and compare.

Kindly review.

--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Aditya Toshniwal
Дата:
Сообщение: [pgAdmin][RM4421] Inno setup script version compare fix
Следующее
От: Dave Page
Дата:
Сообщение: Re: RE-SQL tests for Roles & Resource Group nodes