Re: [pgAdmin][RM4421] Inno setup script version compare fix

Поиск
Список
Период
Сортировка
От Aditya Toshniwal
Тема Re: [pgAdmin][RM4421] Inno setup script version compare fix
Дата
Msg-id CAM9w-_k6dPTtdWpQFNJ0+nYUP0nafzJS4kn+WXXmQ4xyPTHemg@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [pgAdmin][RM4421] Inno setup script version compare fix  (Akshay Joshi <akshay.joshi@enterprisedb.com>)
Ответы Re: [pgAdmin][RM4421] Inno setup script version compare fix  (Akshay Joshi <akshay.joshi@enterprisedb.com>)
Список pgadmin-hackers
Дерево обсуждения
Hi Hackers,

Attached is the updated patch. Instead of float comparison, string comparison is done now with the help of a nice article here - http://www.arvydas.co.uk/2015/04/compare-version-strings-with-innosetup/

Kindly review.

On Tue, Jul 2, 2019 at 2:34 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Aditya 

I have asked Paresh to review the patch, he has given some review comments. Please fix those and the updated patch asap.  

On Tue, Jul 2, 2019 at 1:38 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch to fix a potential issue where version compare while upgrading will be incorrect. Currently, it is comparing strings. So while comparing '4.9' and '4.10' it will consider '4.9' as greater.
The patch will convert the values to float and compare.

Kindly review.

--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246


--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"
Вложения

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Dave Page
Дата:
Сообщение: Re: RE-SQL tests for Roles & Resource Group nodes
Следующее
От: Akshay Joshi
Дата:
Сообщение: pgAdmin 4 commit: Ensure the version comparision should be correct for