Re: [pgAdmin4][Patch] Add formatted error message support in psycopg2

Поиск
Список
Период
Сортировка
От Akshay Joshi
Тема Re: [pgAdmin4][Patch] Add formatted error message support in psycopg2
Дата
Msg-id CANxoLDck1+6BXZvjcQ7bSfGGsnESV74-fWpkuwUsJm8Fuh9GwA@mail.gmail.com
обсуждение исходный текст
Ответ на [pgAdmin4][Patch] Add formatted error message support in psycopg2  (Akshay Joshi <akshay.joshi@enterprisedb.com>)
Ответы Re: [pgAdmin4][Patch] Add formatted error message support in psycopg2  (Akshay Joshi <akshay.joshi@enterprisedb.com>)
Список pgadmin-hackers
Дерево обсуждения
Hi 

On Tue, Mar 29, 2016 at 8:09 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi All 

While implementing Query Tool, I came to know we need error message's with some extra information and also I have faced one issue regarding asynchronous connection polling. I have added support for formatted error message and also fixed the issue. 

Attached is the patch file. Please review it and let me know the review comments if any.

   Apart from above, today I fixed one more issue. In case of user cancel the running transaction, poll function of psycopg2 returns psycopg2.extensions.POLL_OK, which is mislead by the caller of the function, so I have added one flag which will be true if user purposely cancel the transaction and from our poll function we return new status i.e. ASYNC_CANCEL_TRANSACTION.

 Attached is the modified patch. Please review it and if it looks good please commit it.   


--
Akshay Joshi
Principal Software Engineer 


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246



--
Akshay Joshi
Principal Software Engineer 


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246
Вложения

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Murtuza Zabuawala
Дата:
Сообщение: Patch: Added select2cell editor for backgrid [pgAdmin4]
Следующее
От: Harshal Dhumal
Дата:
Сообщение: Tree reload & panel close issue after saving new node on server [pgadmin4]