Re: [PATCH] explain sortorder

Поиск
Список
Период
Сортировка
От Mike Blackwell
Тема Re: [PATCH] explain sortorder
Дата
Msg-id CANPAkgvGG2LgRrvc6CtAZrwX7nGe6R6pXdJ6vc9bBMBtE6nnRQ@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [PATCH] explain sortorder  ("Timmer, Marius" <marius.timmer@uni-muenster.de>)
Ответы Re: [PATCH] explain sortorder  ("Timmer, Marius" <marius.timmer@uni-muenster.de>)
Список pgsql-hackers
V6 of this patch applies, builds and checks against the current HEAD.  The areas below could use some attention.

In explain.c: 

  malloc() should not be called directly here.  palloc() would be the correct call, I believe, but the functions in stringinfo.h are probably your best choice as they remove the necessity for dealing with buffer size and overflow.

  There is leftover commented out code from the previous patch version in the T_Sort case.

  In show_sort_group_keys(), the splitting of the existing declaration and initialization of the keyresno and target seems unnecessary and against the style of surrounding code.

  Multi-line comments should follow the existing format.

There are no tests for the "... is LC_COLLATE" and "COLLATE..." cases.

Section 14.1 of the documentation may need to be updated.


Mike.

__________________________________________________________________________________
Mike Blackwell | Technical Analyst, Distribution Services/Rollout Management | RR Donnelley
1750 Wallace Ave | St Charles, IL 60174-3401
Office: 630.313.7818
Mike.Blackwell@rrd.com
http://www.rrdonnelley.com



On Wed, Jan 7, 2015 at 10:17 AM, Timmer, Marius <marius.timmer@uni-muenster.de> wrote:
Hi,

we have spent the last days to realize your suggestions in the patch.
It affects the result of a EXPLAIN-Statement (even in non-verbose-mode). Now you will get the order-information for every single sort-key which is not ordered by the defaults.


best regards,

Marius




---
Marius Timmer
Zentrum für Informationsverarbeitung
Westfälische Wilhelms-Universität Münster
Einsteinstraße 60

mtimm_01@uni-muenster.de

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Robert Haas
Дата:
Сообщение: Re: parallel mode and parallel contexts
Следующее
От: Tomas Vondra
Дата:
Сообщение: Re: 9.5: Better memory accounting, towards memory-bounded HashAgg