On Wed, Jan 7, 2015 at 10:34 AM, Simon Riggs <simon@2ndquadrant.com> wrote:
> Yes, I didn't mean to suggest the confusion was introduced by you -
> it's just you stepped into the mess by correctly using the word top in
> a place where its meaning would be opposite to the close-by usage of
> TopTransaction.
>
> Anyway, feeling good about this now. Thanks for your patience.
Thanks for the kind words, and the review. Here's a new version with
a much-expanded README and some other changes to the comments to
hopefully address some of your other concerns. I also fixed a couple
of other problems while I was at it: the comments in xact.c claimed
that parallel shutdown waits for workers to exit, but parallel.c
didn't know anything about that. Also, I fixed it so that when an
error is propagated from the parallel worker to the user backend, the
error context in effect at the time the parallel context was created
is used, rather than whatever is in effect when we notice the error.
I have little doubt that this version is still afflicted with various
bugs, and the heavyweight locking issue remains to be dealt with, but
on the whole I think this is headed in the right direction.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company