Re: Remove unused function from walsender.c

Поиск
Список
Период
Сортировка
От Simon Riggs
Тема Re: Remove unused function from walsender.c
Дата
Msg-id CANP8+jLo1CRx=ChqumEPQuNUOSjo-inQdh-hQUFekEY4=M_YCA@mail.gmail.com
обсуждение исходный текст
Ответ на Remove unused function from walsender.c  (Fujii Masao <masao.fujii@gmail.com>)
Ответы Re: Remove unused function from walsender.c  (Fujii Masao <masao.fujii@gmail.com>)
Список pgsql-hackers
On 11 April 2016 at 08:05, Fujii Masao <masao.fujii@gmail.com> wrote:
 
There is an unused function GetOldestWALSendPointer() in walsender.c.
Per comment, it was introduced because we may need it in the future for
synchronous replication.

Now we have very similar function SyncRepGetOldestSyncRecPtr() in
syncrep.c. Which makes me think that GetOldestWALSendPointer()
no longer needs to be maintained. So, is it time to remove that unused
function?

Seems sensible cleanup to me.

--
Simon Riggs                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Simon Riggs
Дата:
Сообщение: Re: Removing the TRACE_SORT macro
Следующее
От: Andres Freund
Дата:
Сообщение: Re: Move PinBuffer and UnpinBuffer to atomics