Hi!
This patch looks very interesting, I'm working on the same subject too. But I've used
another approach - I'm using C wrapper for C++ API library from OpenTelemetry, and
handle span storage and output to this library. There are some nuances though, but it
is possible. Have you tried to use OpenTelemetry APIs instead of implementing all
functionality around spans?
Hi Anthonin,
> I have a working prototype of a pg_tracing extension and wanted some feedback on the design and architecture.
The patch looks very interesting, thanks for working on it and for
sharing. The facts that the patch doesn't change the core except for
two lines in instrument.{c.h} and that is uses pull-based model:
> - Collect the spans through a new pg_tracing_spans() function output
... IMO were the right design decisions. The patch lacks the
documentation, but this is OK for a PoC.
I added the patch to the nearest CF [1]. Let's see what the rest of
the community thinks.
[1] https://commitfest.postgresql.org/44/4456/
--
Best regards,
Aleksander Alekseev
-- Regards,
--
Nikita Malakhov
Postgres Professional
The Russian Postgres Company