Don't wake up to check trigger file if none is configured

Поиск

Список

Период

Сортировка

От	Jeff Janes
Тема	Don't wake up to check trigger file if none is configured
Дата	24 ноября 2018 г. 19:29:22
Msg-id	CAMkU=1y4fJ8YvKpkuw=yTOLAW9_86vyrt2ggMuUBPKOV_zYh-g@mail.gmail.com обсуждение исходный текст
Ответы	Re: Don't wake up to check trigger file if none is configured (Jeff Janes <jeff.janes@gmail.com>) Re: Don't wake up to check trigger file if none is configured (Michael Paquier <michael@paquier.xyz>)
Список	pgsql-hackers

Дерево обсуждения

A streaming replica waiting on WAL from the master will wake up every 5 seconds to check for a trigger file. This is pointless if no trigger file has been configured.

The attached patch suppresses the timeout when there is no trigger file configured.

A minor thing to be sure, but there was a campaign a couple years ago to remove such spurious wake-ups, so maybe this change is worthwhile.

I noticed that the existing codebase does not have a consensus on what to pass to WaitLatch for the timeout when the timeout isn't relevant. I picked 0, but -1L also has precedent.

Cheers,

Jeff