Re: ALTER TABLE ... ALTER CONSTRAINT

Поиск
Список
Период
Сортировка
От Jeff Janes
Тема Re: ALTER TABLE ... ALTER CONSTRAINT
Дата
Msg-id CAMkU=1xjGqkeC4gmp_bz0YBoXznkzBvV0WUA18ZqqXRzM14big@mail.gmail.com
обсуждение исходный текст
Ответ на Re: ALTER TABLE ... ALTER CONSTRAINT  (Abhijit Menon-Sen <ams@2ndQuadrant.com>)
Ответы Re: ALTER TABLE ... ALTER CONSTRAINT  (Simon Riggs <simon@2ndQuadrant.com>)
Список pgsql-hackers
On Sun, Jun 23, 2013 at 8:58 PM, Abhijit Menon-Sen <ams@2ndquadrant.com> wrote:
At 2013-06-08 21:45:24 +0100, simon@2ndQuadrant.com wrote:
>
> ALTER TABLE foo
>    ALTER CONSTRAINT fktable_fk_fkey DEFERRED INITIALLY IMMEDIATE;

I read the patch (looks good), applied it on HEAD (fine), ran make check
(fine), and played with it in a test database. It looks great, and from
previous responses it's something a lot of people have wished for.

I'm marking this ready for committer.

After the commit, I'm now getting the compiler warning:

tablecmds.c: In function 'ATPrepCmd':
tablecmds.c:2953: warning: 'pass' may be used uninitialized in this function


case AT_AlterConstraint (line 3130) is the only case branch that does not set pass.

Cheers,

Jeff

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Josh Berkus
Дата:
Сообщение: Re: patch submission: truncate trailing nulls from heap rows to reduce the size of the null bitmap [Review]
Следующее
От: Tom Lane
Дата:
Сообщение: Re: patch submission: truncate trailing nulls from heap rows to reduce the size of the null bitmap [Review]