Re:

Поиск
Список
Период
Сортировка
От Neel Patel
Тема Re:
Дата
Msg-id CAMcbDBF8Q5-j2qQ0bmxAuxAJLGckyO2H_nPxODGPQxLfDmuPeA@mail.gmail.com
обсуждение исходный текст
Ответ на  (Neel Patel <neel.patel@enterprisedb.com>)
Ответы Re:  (Dave Page <dave.page@enterprisedb.com>)
Список pgadmin-hackers
Hi Dave,

Sorry forgot to add the flag wxFLP_USE_TEXTCTRL at two places in dlgServer.xrc file . so attached updated patch file.


Thanks,
Neel Patel


On Wed, May 22, 2013 at 4:35 PM, Neel Patel <neel.patel@enterprisedb.com> wrote:
Hi Dave,

Rohit found one crash while we add the servers in the PEM.

With the help of Ashesh we debug the code and found that crash is due to below changes of SSL certificate authentication.


commit 5a7d5b32128c950e232d8239a35dcbd08b36a237
Author: Dave Page <dpage@pgadmin.org>
Date:   Fri May 17 10:11:54 2013 +0100

   Fix SSL certificate authentication.


Analysis:

We found the crash in the function CreateObject(pgCollection *collection) in dlg/dlgServer.cpp at below line.

obj->SetSSLCert(pickerSSLCert->GetTextCtrlValue());


At above line returns a pointer to the text control handle by window and we have not set the wxFLP_USE_TEXTCTRL flag. so when we create the file picker object and if we not specified the wxFLP_USE_TEXTCTRL flag then it return NULL pointer of text control.

So we have set the flag wxFLP_USE_TEXTCTRL in the ui file dlgServer.ui to fix the issue.

Please find the patch in attachement.

Thanks,
Neel Patel


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Вложения

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Neel Patel
Дата:
Сообщение:
Следующее
От: Dave Page
Дата:
Сообщение: pgAdmin III commit: Use a textbox with file pickers.