Re: lastOverflowedXid does not handle transaction ID wraparound

Поиск
Список
Период
Сортировка
От Stan Hu
Тема Re: lastOverflowedXid does not handle transaction ID wraparound
Дата
Msg-id CAMBWrQmMLNhmbO5v65hKMZcd2q_u_TuZ2J2GkG-Fe_CmccubGw@mail.gmail.com
обсуждение исходный текст
Ответ на Re: lastOverflowedXid does not handle transaction ID wraparound  (Alexander Korotkov <aekorotkov@gmail.com>)
Список pgsql-hackers
Дерево обсуждения
Good catch on doing this in ExpireAllKnownAssignedTransactionIds() as well. Thanks. Looks good to me!

As Nikolay mentioned, I think this is an important bug that we are seeing in production and would appreciate a backport to v12 if possible.

On Wed, Nov 3, 2021 at 3:07 PM Alexander Korotkov <aekorotkov@gmail.com> wrote:
Hi!

On Wed, Nov 3, 2021 at 8:51 PM Simon Riggs <simon.riggs@enterprisedb.com> wrote:
> It is however, an undocumented modularity violation. I think that is
> acceptable because of the ProcArrayLock traffic, but needs to have a
> comment to explain this at the call to
> ExpireOldKnownAssignedTransactionIds() i.e. " and potentially reset
> lastOverflowedXid", as well as a comment on the
> ExpireOldKnownAssignedTransactionIds() function.

Thank you for your feedback.  Please find the revised patch attached.
It incorporates this function comment changes altogether with minor
editings and commit message. Let me know if you have further
suggestions.

I'm going to push this if no objections.

------
Regards,
Alexander Korotkov

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Mark Dilger
Дата:
Сообщение: Re: minor gripe about lax reloptions parsing for views
Следующее
От: Peter Geoghegan
Дата:
Сообщение: Why doesn't GiST VACUUM require a super-exclusive lock, like nbtree VACUUM?