Re: [pgAdmin][RM6520]: pgAdmin4 v 5.3 text export error

Поиск
Список
Период
Сортировка
От Aditya Toshniwal
Тема Re: [pgAdmin][RM6520]: pgAdmin4 v 5.3 text export error
Дата
Msg-id CAM9w-_kyf8reg8pw+qa=CaRKiU0i5Vfmyj34BSDSTXB6dP8w4w@mail.gmail.com
обсуждение исходный текст
Ответ на [pgAdmin][RM6520]: pgAdmin4 v 5.3 text export error  (Pradip Parkale <pradip.parkale@enterprisedb.com>)
Ответы Re: [pgAdmin][RM6520]: pgAdmin4 v 5.3 text export error  (Pradip Parkale <pradip.parkale@enterprisedb.com>)
Список pgadmin-hackers
Дерево обсуждения
Hi Pradip,

Just did a go through to your patch. 
The variable "data" which you've formed, will be computed for every row even though columns won't change. You should move it up and pass it to gen directly. This will save repeated computations.
Secondly, it should not be named as data. It can be like - numeric_cols or numeric_keys.

On Fri, Jun 11, 2021 at 7:17 PM Pradip Parkale <pradip.parkale@enterprisedb.com> wrote:
Hi Hackers,

Please find the attached patch for #6520.Added check to typecast the numeric data while downloading the data in CSV format.

--
Thanks & Regards,
Pradip Parkale
Software Engineer | EnterpriseDB Corporation


--
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Akshay Joshi
Дата:
Сообщение: pgAdmin 4 commit: Fixed issues related to About dialog:
Следующее
От: Akshay Joshi
Дата:
Сообщение: Re: [pgAdmin][RM6231]- Add OS, Browser details in pgAdmin About us pop-up