Re: [pgAdmin][RM6520]: pgAdmin4 v 5.3 text export error

Поиск
Список
Период
Сортировка
От Pradip Parkale
Тема Re: [pgAdmin][RM6520]: pgAdmin4 v 5.3 text export error
Дата
Msg-id CAJ9T6SspOyknEZhG7MyCWmFt=bBYcrhMNkCxs2kCaXAQiQSOVA@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [pgAdmin][RM6520]: pgAdmin4 v 5.3 text export error  (Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>)
Список pgadmin-hackers
Дерево обсуждения
Hi Aditya and Akshay,

Please find the updated patch. I have changed the variable name "data" to 'numeric_cols'.

On Fri, Jun 11, 2021 at 7:38 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Pradip,

Just did a go through to your patch. 
The variable "data" which you've formed, will be computed for every row even though columns won't change. You should move it up and pass it to gen directly. This will save repeated computations.
Secondly, it should not be named as data. It can be like - numeric_cols or numeric_keys.

On Fri, Jun 11, 2021 at 7:17 PM Pradip Parkale <pradip.parkale@enterprisedb.com> wrote:
Hi Hackers,

Please find the attached patch for #6520.Added check to typecast the numeric data while downloading the data in CSV format.

--
Thanks & Regards,
Pradip Parkale
Software Engineer | EnterpriseDB Corporation


--
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards,
Pradip Parkale
Software Engineer | EnterpriseDB Corporation
Вложения

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Nikhil Mohite
Дата:
Сообщение: [pgAdmin][RM-6469]: Role node: Calender control is not disabled in properties panel
Следующее
От: Nikhil Mohite
Дата:
Сообщение: Re: [pgAdmin][RM-2341]: Add menu option for starting PSQL