Re: [pgadmin-hackers] pgAdmin 4 commit: Use a more sensible name forQuery Tool tabs. Fixes #

Поиск
Список
Период
Сортировка
От Surinder Kumar
Тема Re: [pgadmin-hackers] pgAdmin 4 commit: Use a more sensible name forQuery Tool tabs. Fixes #
Дата
Msg-id CAM5-9D9o1dOXNC3iNXi0H4jy1mmXAC0HdAFz2p98Y5tF9NPGjg@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [pgadmin-hackers] pgAdmin 4 commit: Use a more sensible name forQuery Tool tabs. Fixes #  (Harshal Dhumal <harshal.dhumal@enterprisedb.com>)
Ответы Re: [pgadmin-hackers] pgAdmin 4 commit: Use a more sensible name forQuery Tool tabs. Fixes #  (Dave Page <dpage@pgadmin.org>)
Список pgadmin-hackers
Hi 

PFA patch which fixes the issue Harshal reported.

Thanks,
Surinder

On Thu, Jun 15, 2017 at 3:52 AM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Surinder,

I guess this broke the script options (Create, Delete, Select, Insert, Update)


VM4124 datagrid.js:440
Uncaught TypeError: self.get_panel_title is not a function at Object.success (VM4124 datagrid.js:440) at fire (jquery-1.11.2.js:3143) at Object.fireWith [as resolveWith] (jquery-1.11.2.js:3255) at done (jquery-1.11.2.js:9309) at XMLHttpRequest.callback (jquery-1.11.2.js:9713)
success@VM4124 datagrid.js:440
fire@jquery-1.11.2.js:3143
fireWith@jquery-1.11.2.js:3255
done@jquery-1.11.2.js:9309
callback@jquery-1.11.2.js:9713




-- 
Harshal Dhumal
Sr. Software Engineer

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Tue, Jun 13, 2017 at 4:04 PM, Dave Page <dpage@pgadmin.org> wrote:
Use a more sensible name for Query Tool tabs. Fixes #2482

Branch
------
master

Details
-------
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=57d866f7b70996a82a881b20248c3285ab3a6900
Author: Surinder Kumar <surinder.kumar@enterprisedb.com>

Modified Files
--------------
web/pgadmin/browser/templates/browser/js/node.js   |  4 +-
web/pgadmin/static/css/webcabin.overrides.css      | 13 +++++
.../datagrid/templates/datagrid/js/datagrid.js     | 58 ++++++++++++----------
.../sqleditor/templates/sqleditor/js/sqleditor.js  |  5 +-
4 files changed, 49 insertions(+), 31 deletions(-)


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Вложения

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Harshal Dhumal
Дата:
Сообщение: Re: [pgadmin-hackers] Re: Server side cursor limitations for ondemand loading of data in query tool [RM2137] [pgAdmin4]
Следующее
От: Surinder Kumar
Дата:
Сообщение: Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2482]: Query tool/ Edit grid panel should have meaningful title