[pgAdmin4][Patch]: RM_2596 - Query tool not working in DesktopRuntime on Mac OS X

Поиск
Список
Период
Сортировка
От Surinder Kumar
Тема [pgAdmin4][Patch]: RM_2596 - Query tool not working in DesktopRuntime on Mac OS X
Дата
Msg-id CAM5-9D83KF2KzmDA6o95V1a=7DA609z_HT3cT-FHrv4ZcPMDOA@mail.gmail.com
обсуждение исходный текст
Ответы Re: [pgAdmin4][Patch]: RM_2596 - Query tool not working in DesktopRuntime on Mac OS X  (Dave Page <dpage@pgadmin.org>)
Re: [pgAdmin4][Patch]: RM_2596 - Query tool not working in DesktopRuntime on Mac OS X  (Ashesh Vashi <ashesh.vashi@enterprisedb.com>)
Список pgadmin-hackers
Hi,

I inspect the react code and in call stacks, found `process.env.NODE_ENV` is undefined due to which 'SyntheticEvent.call' is not callable.

So, to fix this, i add 'definePlugin' to plugins for `dev` environment in `webpack.config.js`. Initially it was added only for `production` environment. but it is needed for both, because React code is conditional based on environment variables set.

Please find attached patch and review.

Thanks,
Surinder
Вложения

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Akshay Joshi
Дата:
Сообщение: Re: Discussion on improving alertify notifications logic
Следующее
От: Dave Page
Дата:
Сообщение: Re: Discussion on improving alertify notifications logic