Re: [pgAdmin4][Patch]: RM_2596 - Query tool not working in DesktopRuntime on Mac OS X

Поиск
Список
Период
Сортировка
От Ashesh Vashi
Тема Re: [pgAdmin4][Patch]: RM_2596 - Query tool not working in DesktopRuntime on Mac OS X
Дата
Msg-id CAG7mmoyjX7owVvnA5nHEs8cx832ywKbGUSJM6HU9k=eqcBoBYQ@mail.gmail.com
обсуждение исходный текст
Ответ на [pgAdmin4][Patch]: RM_2596 - Query tool not working in DesktopRuntime on Mac OS X  (Surinder Kumar <surinder.kumar@enterprisedb.com>)
Ответы Re: [pgAdmin4][Patch]: RM_2596 - Query tool not working in DesktopRuntime on Mac OS X  (Surinder Kumar <surinder.kumar@enterprisedb.com>)
Список pgadmin-hackers
Дерево обсуждения
On Fri, Jul 28, 2017 at 12:42 PM, Surinder Kumar <surinder.kumar@enterprisedb.com> wrote:
Hi,

I inspect the react code and in call stacks, found `process.env.NODE_ENV` is undefined due to which 'SyntheticEvent.call' is not callable.

So, to fix this, i add 'definePlugin' to plugins for `dev` environment in `webpack.config.js`. Initially it was added only for `production` environment. but it is needed for both, because React code is conditional based on environment variables set. 

Please find attached patch and review.
As discussed, you're setting 'production', even in the 'development' mode.

Please understand the code, and share the updated patch.
Also - share the references next time, so that - committer can understand the reason for these changes.

-- Thanks, Ashesh

Thanks,
Surinder

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Ashesh Vashi
Дата:
Сообщение: Re: Discussion on improving alertify notifications logic
Следующее
От: Rahul Peddapalli
Дата:
Сообщение: Re-open Dashboard