Re: Doing better at HINTing an appropriate column within errorMissingColumn()
От
Peter Geoghegan
Тема
Re: Doing better at HINTing an appropriate column within errorMissingColumn()
Дата
Msg-id
CAM3SWZRvoMM22ANS6JopneNtDccttntn_OygzkA+ymgLRrLF9w@mail.gmail.com
Ответ на
Список
Дерево обсуждения
Doing better at HINTing an appropriate column within errorMissingColumn() Peter Geoghegan <pg@heroku.com>
Re: Doing better at HINTing an appropriate column within
errorMissingColumn() Albe Laurenz <laurenz.albe@wien.gv.at>
Re: Doing better at HINTing an appropriate column within
errorMissingColumn() Christoph Berg <cb@df7cb.de>
Re: Doing better at HINTing an appropriate column within errorMissingColumn() Robert Haas <robertmhaas@gmail.com>
Re: Doing better at HINTing an appropriate column within errorMissingColumn() Peter Geoghegan <pg@heroku.com>
Re: Doing better at HINTing an appropriate column within
errorMissingColumn() Jim Nasby <jim@nasby.net>
Re: Doing better at HINTing an appropriate column within errorMissingColumn() Greg Stark <stark@mit.edu>
Re: Doing better at HINTing an appropriate column within
errorMissingColumn() Andres Freund <andres@2ndquadrant.com>
Re: Doing better at HINTing an appropriate column within errorMissingColumn() Greg Stark <stark@mit.edu>
Re: Doing better at HINTing an appropriate column within
errorMissingColumn() Andres Freund <andres@2ndquadrant.com>
Re: Doing better at HINTing an appropriate column within errorMissingColumn() Peter Geoghegan <pg@heroku.com>
Re: Doing better at HINTing an appropriate column within errorMissingColumn() Michael Paquier <michael.paquier@gmail.com>
Re: Doing better at HINTing an appropriate column within errorMissingColumn() Peter Geoghegan <pg@heroku.com>
Re: Doing better at HINTing an appropriate column within errorMissingColumn() Oleg Bartunov <obartunov@gmail.com>
Re: Doing better at HINTing an appropriate column within errorMissingColumn() Pavel Stehule <pavel.stehule@gmail.com>
Re: Doing better at HINTing an appropriate column within errorMissingColumn() Peter Geoghegan <pg@heroku.com>
Re: Doing better at HINTing an appropriate column within errorMissingColumn() Pavel Stehule <pavel.stehule@gmail.com>
On Mon, Jun 16, 2014 at 7:09 PM, Ian Barwick wrote: > Howver in this particular use case, as long as it doesn't produce false > positives (I haven't looked at the patch) I don't think it would cause > any problems (of the kind which would require actively excluding certain > languages/character sets), it just wouldn't be quite as useful. I'm not sure what you mean by false positives. The patch just shows a HINT, where before there was none. It's possible for any number of reasons that it isn't the most useful possible suggestion, since Levenshtein distance is used as opposed to any other scheme that might be better sometimes. I think that the hint given is a generally useful piece of information in the event of an ERRCODE_UNDEFINED_COLUMN error. Obviously I think the patch is worthwhile, but fundamentally the HINT given is just a guess, as with the existing HINTs. -- Peter Geoghegan
В списке pgsql-hackers по дате отправления
От: Ian Barwick
Дата: