Re: basebackup.c's sendFile() ignores read errors

Поиск
Список
Период
Сортировка
От Jeevan Chalke
Тема Re: basebackup.c's sendFile() ignores read errors
Дата
Msg-id CAM2+6=XhqoKikwEDs5b-BQFVGYSArSRwTkbWeDAap9g1NXh-Rg@mail.gmail.com
обсуждение исходный текст
Ответ на Re: basebackup.c's sendFile() ignores read errors  (Robert Haas <robertmhaas@gmail.com>)
Ответы Re: basebackup.c's sendFile() ignores read errors  (Robert Haas <robertmhaas@gmail.com>)
Список pgsql-hackers
Дерево обсуждения


On Thu, Sep 5, 2019 at 11:40 PM Robert Haas <robertmhaas@gmail.com> wrote:
On Fri, Aug 30, 2019 at 7:05 AM Jeevan Ladhe
<jeevan.ladhe@enterprisedb.com> wrote:
>> Fixed both comments in the attached patch.
>
> Thanks, the patch looks good to me.

Here's a version of the patch with a further change to the wording of
the comment.  I hope this is clearer.

Yep.
 

I think this needs to be back-patched all the way back to 9.4, and it
doesn't seem to apply cleanly before v11.  Any chance you could
prepare a version for the older branches?

Attached patch for v10 and pre. The same v10 patch applies cleanly.

Changes related to the page checksum verification is not present on v10 and
pre, and thus those changes are not applicable, so removed those.  Also,
wal_segment_size is XLogSegSize over there, adjusted that.
 

Thanks,

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Thanks
--
Jeevan Chalke
Technical Architect, Product Development
EnterpriseDB Corporation
The Enterprise PostgreSQL Company

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Amit Langote
Дата:
Сообщение: Re: CVE-2017-7484-induced bugs, or, btree cmp functions are not leakproof?
Следующее
От: Andrey Borodin
Дата:
Сообщение: Re: amcheck verification for GiST