Re: block-level incremental backup

Поиск
Список
Период
Сортировка
От Jeevan Chalke
Тема Re: block-level incremental backup
Дата
Msg-id CAM2+6=WV8_Lp9Fng3o8jKri3Wa21_0oxh6dunE5qdXvSWZQ6SQ@mail.gmail.com
обсуждение исходный текст
Ответ на Re: block-level incremental backup  (Robert Haas <robertmhaas@gmail.com>)
Ответы Re: block-level incremental backup  (Ibrar Ahmed <ibrar.ahmad@gmail.com>)
Re: block-level incremental backup  (Robert Haas <robertmhaas@gmail.com>)
Список pgsql-hackers
Дерево обсуждения


On Mon, Aug 5, 2019 at 7:13 PM Robert Haas <robertmhaas@gmail.com> wrote:
On Fri, Aug 2, 2019 at 9:13 AM vignesh C <vignesh21@gmail.com> wrote:
> + rc = system(copycmd);

I don't think this patch should be calling system() in the first place.

So, do you mean we should just do fread() and fwrite() for the whole file?

I thought it is better if it was done by the OS itself instead of reading 1GB
into the memory and writing the same to the file.


--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Jeevan Chalke
Technical Architect, Product Development
EnterpriseDB Corporation
The Enterprise PostgreSQL Company

В списке pgsql-hackers по дате отправления:

Предыдущее
От: vignesh C
Дата:
Сообщение: Re: SegFault on 9.6.14
Следующее
От: Liudmila Mantrova
Дата:
Сообщение: Re: s/rewinded/rewound/?