Re: Add new error_action COPY ON_ERROR "log"

On Thu, Mar 28, 2024 at 6:31 PM Masahiko Sawada <sawada.mshk@gmail.com> wrote:
>
> That is,
> since the LOG_VERBOSITY option is an enum parameter, it might make
> more sense to require the value, instead of making the value optional.
> For example, the following command could not be obvious for users:
>
> COPY test FROM stdin (ON_ERROR ignore, LOG_VERBOSITY);

Agreed. Please see the attached v14 patch. The LOG_VERBOSITY now needs
a value to be specified. Note that I've not added any test for this
case as there seemed to be no such tests so far generating "ERROR:
<<option>> requires a parameter". I don't mind adding one for
LOG_VERBOSITY though.

--
Bharath Rupireddy
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com