Re: [PATCH] Remove Extra palloc Of raw_buf For Binary Format In COPY FROM

Поиск
Список
Период
Сортировка
От Bharath Rupireddy
Тема Re: [PATCH] Remove Extra palloc Of raw_buf For Binary Format In COPY FROM
Дата
Msg-id CALj2ACU_V2Jf2shpoj0zV0VmpfarSu842XW1nn10CjcjUAHD+w@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [PATCH] Remove Extra palloc Of raw_buf For Binary Format In COPY FROM  (Tom Lane <tgl@sss.pgh.pa.us>)
Ответы Re: [PATCH] Remove Extra palloc Of raw_buf For Binary Format In COPY FROM  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-hackers
On Sat, Jul 11, 2020 at 11:53 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> vignesh C <vignesh21@gmail.com> writes:
> > On Tue, Jun 30, 2020 at 2:41 PM Bharath Rupireddy
> > <bharath.rupireddyforpostgres@gmail.com> wrote:
> >> I've added this patch to commitfest - https://commitfest.postgresql.org/28/.
>
> > I felt this patch is ready for committer, changing the status to ready
> > for committer.
>
> Pushed with some fiddling.  Mainly, if we're going to the trouble of
> checking for binary mode here, we might as well skip allocating the
> line_buf too.
>

Hi Tom,

Isn't it good if we backpatch this to versions 13, 12, 11 and so on?
As we can save good amount of memory with this patch for non-binary
copy.

Attaching the patch which applies on versions 13, 12, 11.

With Regards,
Bharath Rupireddy.
EnterpriseDB: http://www.enterprisedb.com

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Noah Misch
Дата:
Сообщение: Re: Which SET TYPE don't actually require a rewrite
Следующее
От: Tom Lane
Дата:
Сообщение: Re: [PATCH] Remove Extra palloc Of raw_buf For Binary Format In COPY FROM