Re: [PATCH] Remove Extra palloc Of raw_buf For Binary Format In COPY FROM

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: [PATCH] Remove Extra palloc Of raw_buf For Binary Format In COPY FROM
Дата
Msg-id 3919002.1595048601@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: [PATCH] Remove Extra palloc Of raw_buf For Binary Format In COPY FROM  (Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>)
Список pgsql-hackers
Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com> writes:
> On Sat, Jul 11, 2020 at 11:53 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Pushed with some fiddling.  Mainly, if we're going to the trouble of
>> checking for binary mode here, we might as well skip allocating the
>> line_buf too.

> Isn't it good if we backpatch this to versions 13, 12, 11 and so on?

Given the lack of complaints, I wasn't excited about it.  Transient
consumption of 64K is not a huge deal these days.  (And yes, I've
worked on machines where that was the entire address space.  But that
was a very long time ago.)

            regards, tom lane



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Bharath Rupireddy
Дата:
Сообщение: Re: [PATCH] Remove Extra palloc Of raw_buf For Binary Format In COPY FROM
Следующее
От: John Naylor
Дата:
Сообщение: Re: factorial function/phase out postfix operators?