On Wed, 10 Jul 2024 at 09:34, Peter Smith <smithpb2250@gmail.com> wrote:
>
> On Fri, Jul 5, 2024 at 9:58 PM vignesh C <vignesh21@gmail.com> wrote:
> >
> > On Thu, 4 Jul 2024 at 12:44, Peter Smith <smithpb2250@gmail.com> wrote:
> > >
> > > 1.
> > > Should there be some new test for the view? Otherwise, AFAICT this
> > > patch has no tests that will exercise the new function
> > > pg_get_publication_sequences.
> >
> > pg_publication_sequences view uses pg_get_publication_sequences which
> > will be tested with 3rd patch while creating subscription/refreshing
> > publication sequences. I felt it is ok not to have a test here.
> >
>
> OTOH, if there had been such a test here then the ("sequence = NIL")
> bug in patch 0002 code would have been caught earlier in patch 0002
> testing instead of later in patch 0003 testing. In general, I think
> each patch should be self-contained w.r.t. to testing all of its new
> code, but if you think another test here is overkill then I am fine
> with that too.
Moved these changes to 0003 patch where it is actually required.
> //////////
>
> Meanwhile, here are my review comments for patch v20240705-0002
All the comments are fixed and the attached v20240720 version patch
has the changes for the same.
Regards,
Vignesh