Re: Include access method in listTables output

On Tue, Jun 16, 2020 at 6:13 PM Georgios <gkokolatos@protonmail.com> wrote:
> > Few comments:
> >
> > -   if (pset.sversion >= 120000)
> >
> > -   appendPQExpBufferStr(&buf,
> >
> > -   "\n LEFT JOIN pg_catalog.pg_am am ON am.oid = c.relam");
> >
> >     Should we include pset.hide_tableam check along with the version check?
>
> I opted against it, since it seems more intuitive to have a single
> switch and placed on the display part. A similar pattern can be found
> in describeOneTableDetails(). I do not hold a strong opinion and will
> gladly ament if insisted upon.
>

I felt we could add that check as we might be including
pg_catalog.pg_am in cases even though we really don't need it.

Regards,
Vignesh
EnterpriseDB: http://www.enterprisedb.com