Re: [patch][pgAdmin] Fix for pgadmin4-linux-qa #1651 failure

Поиск
Список
Период
Сортировка
От Rahul Shirsat
Тема Re: [patch][pgAdmin] Fix for pgadmin4-linux-qa #1651 failure
Дата
Msg-id CAKtn9dOWXDQo9K_HuqGOmhq=AeVVzcE8d=J+8obRj014G=0jxQ@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [patch][pgAdmin] Fix for pgadmin4-linux-qa #1651 failure  (Dave Page <dpage@pgadmin.org>)
Ответы Re: [patch][pgAdmin] Fix for pgadmin4-linux-qa #1651 failure  (Dave Page <dpage@pgadmin.org>)
Список pgadmin-hackers
Дерево обсуждения
I feel gettext sometimes won't escape the characters as it should be.

I now tried to escape those using some utils.

Please find the updated patch.

On Mon, Jun 28, 2021 at 9:33 PM Dave Page <dpage@pgadmin.org> wrote:
Hi

On Mon, Jun 28, 2021 at 4:57 PM Rahul Shirsat <rahul.shirsat@enterprisedb.com> wrote:
Hi Hackers,

Please find the attached patch for fixation of jenkins failure.

That won't work - you can't include variables (or string building operations) in the first argument to gettext calls, as there won't be any way to extract a complete message into the catalogs. The way it's being done at the moment is correct (I don't know why it's failing, but it's the correct way to structure the gettext calls).
 
--


--
Rahul Shirsat
Senior Software Engineer | EnterpriseDB Corporation.
Вложения

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Dave Page
Дата:
Сообщение: Re: [patch][pgAdmin] Fix for pgadmin4-linux-qa #1651 failure
Следующее
От: Dave Page
Дата:
Сообщение: Re: [patch][pgAdmin] Fix for pgadmin4-linux-qa #1651 failure