Re: Fix the miss consideration of tuple_fraction during add_paths_to_append_rel

Поиск
Список
Период
Сортировка
От Andy Fan
Тема Re: Fix the miss consideration of tuple_fraction during add_paths_to_append_rel
Дата
Msg-id CAKU4AWrwRbtO4+a+WhLG-2TG3hk-oFNTdt5p=1GYp+4jk+-PeA@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Fix the miss consideration of tuple_fraction during add_paths_to_append_rel  (Zhang Mingli <zmlpostgres@gmail.com>)
Список pgsql-hackers


On Mon, Apr 10, 2023 at 9:56 PM Zhang Mingli <zmlpostgres@gmail.com> wrote:

There is spare indent at else if.

- if (childrel->pathlist != NIL &&
+ if (cheapest_startup_path && cheapest_startup_path->param_info == NULL)
+ accumulate_append_subpath(cheapest_startup_path,
+   &subpaths, NULL);
+ else if (childrel->pathlist != NIL &&
  childrel->cheapest_total_path->param_info == NULL)
  accumulate_append_subpath(childrel->cheapest_total_path,
    &subpaths, NULL);

Could we also consider tuple_fraction in partial_pathlist for  parallel append?

 
Thanks for the suggestion,  the v2 has fixed the indent issue and I did
something about parallel append.  Besides that,  I restrict the changes
happens under bms_equal(rel->relids, root->all_query_rels), which may
make this patch safer. 


--
Best Regards
Andy Fan
Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Alvaro Herrera
Дата:
Сообщение: Re: When to drop src/tools/msvc support
Следующее
От: Andres Freund
Дата:
Сообщение: Re: Direct I/O