Re: Patch to improve a few appendStringInfo* calls

Поиск
Список
Период
Сортировка
От David Rowley
Тема Re: Patch to improve a few appendStringInfo* calls
Дата
Msg-id CAKJS1f_R74sqUEvEeHNe_TDyDqqPKttKerGOyzAX=XOfQ_Nx7A@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Patch to improve a few appendStringInfo* calls  (Heikki Linnakangas <hlinnaka@iki.fi>)
Ответы Re: Patch to improve a few appendStringInfo* calls  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Re: Patch to improve a few appendStringInfo* calls  (Robert Haas <robertmhaas@gmail.com>)
Список pgsql-hackers
Дерево обсуждения
On 2 July 2015 at 21:59, Heikki Linnakangas <hlinnaka@iki.fi> wrote:
Applied the straightforward parts.

Thanks for committing.
 
I left out the changes like

-               appendStringInfoString(&collist, buf.data);
+               appendBinaryStringInfo(&collist, buf.data, buf.len);

because they're not an improvement in readablity, IMHO, and they were not in performance-critical paths.

 
Perhaps we can come up with appendStringInfoStringInfo at some later date.

--
 David Rowley                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Heikki Linnakangas
Дата:
Сообщение: Re: Patch to improve a few appendStringInfo* calls
Следующее
От: Simon Riggs
Дата:
Сообщение: Re: Let PostgreSQL's On Schedule checkpoint write buffer smooth spread cycle by tuning IsCheckpointOnSchedule?