Re: Patch to improve a few appendStringInfo* calls
| От | Alvaro Herrera |
|---|---|
| Тема | Re: Patch to improve a few appendStringInfo* calls |
| Дата | |
| Msg-id | 20150702134509.GK3289@postgresql.org обсуждение исходный текст |
| Ответ на | Re: Patch to improve a few appendStringInfo* calls (David Rowley <david.rowley@2ndquadrant.com>) |
| Список | pgsql-hackers |
David Rowley wrote: > On 2 July 2015 at 21:59, Heikki Linnakangas <hlinnaka@iki.fi> wrote: > > > I left out the changes like > > > > - appendStringInfoString(&collist, buf.data); > >> + appendBinaryStringInfo(&collist, buf.data, buf.len); > >> > > > > because they're not an improvement in readablity, IMHO, and they were not > > in performance-critical paths. > > > Perhaps we can come up with appendStringInfoStringInfo at some later date. I had this exact thought when I saw your patch (though it was appendStringInfoSI to me because the other name is too long and a bit confusing). It seems straightforward enough ... -- Álvaro Herrera http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
В списке pgsql-hackers по дате отправления: