Re: [HACKERS] Patch: Add --no-comments to skip COMMENTs with pg_dump

Поиск
Список
Период
Сортировка
От David G. Johnston
Тема Re: [HACKERS] Patch: Add --no-comments to skip COMMENTs with pg_dump
Дата
Msg-id CAKFQuwZuYhh+KUzp76cdB4r8Z616ZwEWcHEEDq6vEqgdGP9QZw@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [HACKERS] Patch: Add --no-comments to skip COMMENTs with pg_dump  (Simon Riggs <simon@2ndquadrant.com>)
Список pgsql-hackers
Дерево обсуждения
On Mon, Aug 21, 2017 at 2:30 PM, Simon Riggs <simon@2ndquadrant.com> wrote:

> The patch applies cleanly to current master and all tests run without
> failures.
>
> I also test against all current supported versions (9.2 ... 9.6) and didn't
> find any issue.
>
> Changed status to "ready for commiter".

I get the problem, but not this solution. It's too specific and of
zero other value, yet not even exactly specific to the issue. We
definitely don't want --no-extension-comments, but --no-comments
removes ALL comments just to solve a weird problem. (Meta)Data loss,
surely?

​It was argued, successfully IMO, to have this capability independent of any particular problem to be solved.  In that context I haven't given the proposed implementation much thought.

I do agree that this is a very unappealing solution for the stated problem and am hoping someone will either have an ingenious idea to solve it the right way or is willing to hold their nose and put in a hack.

David J.

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Peter Eisentraut
Дата:
Сообщение: Re: [HACKERS] Re: ICU collation variant keywords and pg_collationentries (Was: [BUGS] Crash report for some ICU-52 (debian8) COLLATE andwork_mem values)
Следующее
От: Michael Paquier
Дата:
Сообщение: Re: [HACKERS] Setting pd_lower in GIN metapage