Re: proposal: psql \setfileref

Поиск
Список
Период
Сортировка
От Haribabu Kommi
Тема Re: proposal: psql \setfileref
Дата
Msg-id CAJrrPGeY1Q22EczoayEP5zdBbPBd8zWdssO746U-nz5pPEF-mA@mail.gmail.com
обсуждение исходный текст
Ответ на Re: proposal: psql \setfileref  (Pavel Stehule <pavel.stehule@gmail.com>)
Список pgsql-hackers


On Fri, Nov 18, 2016 at 5:53 AM, Pavel Stehule <pavel.stehule@gmail.com> wrote:
Hi

2016-11-17 12:00 GMT+01:00 Pavel Stehule <pavel.stehule@gmail.com>:

Hi

a independent implementation of parametrized queries can looks like attached patch:

this code is simple without any unexpected behave.

parameters are used when user doesn't require escaping and when PARAMETRIZED_QUERIES variable is on

Regards

here is a Daniel's syntax patch

The independent implementation of using query parameters is good idea, the patch looks well, and there is a agreement with Tom.

I implemented a Daniel proposal - it is few lines, but personally I prefer curly bracket syntax against `` syntax. When separator is double char, then the correct implementation will not be simple - the bad combinations "` ``, `` `" should be handled better. I wrote my arguments for my design, but if these arguments are not important for any other, then I can accept any other designs.


The recent updated patch as per the agreement hasn't received any feedback
from reviewers. Moved to next CF with "needs review" status.

Regards,
Hari Babu
Fujitsu Australia

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Haribabu Kommi
Дата:
Сообщение: Re: pgbench - allow backslash continuations in \set expressions
Следующее
От: Haribabu Kommi
Дата:
Сообщение: Re: Danger of automatic connection reset in psql