On Wed, Dec 1, 2021 at 10:15 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> Thanks, your patch looks good to me. I have slightly changed the
> comments and commit message in the attached.
>
I'd suggest tidying the patch comment a bit:
"We publish the child table's data twice for a publication that has both
child and parent tables and is published with publish_via_partition_root
as true. This happens because subscribers will initiate synchronization
using both parent and child tables, since it gets both as separate tables
in the initial table list."
Also, perhaps the following additional comment (or similar) could be
added to the pg_publication_tables documentation in catalogs.sgml:
For publications of partitioned tables with publish_via_partition_root
set to true, the partitioned table itself (rather than the individual
partitions) is included in the view.
> I think we should back-patch this but I am slightly worried ...
I'd be in favor of back-patching this.
Regards,
Greg Nancarrow
Fujitsu Australia