On 10 April 2018 at 10:36, Teodor Sigaev <teodor@sigaev.ru> wrote:
>> Does the attached fix look correct? Haven't checked the fix with
>> ATTACH
>> PARTITION though.
>>
>>
>> Attached patch seems to fix the problem. However, I would rather get
>> rid of modifying stmt->indexParams. That seems to be more logical
>> for me. Also, it would be good to check some covering indexes on
>> partitioned tables. See the attached patch.
>
> Seems right way, do not modify incoming object and do not copy rather large
> and deep nested structure as suggested by Amit.
>
> But it will be better to have a ATTACH PARTITION test too.
>
the patch worked for me, i also tried some combinations using ATTACH
PARTITION and found no problems
--
Jaime Casanova www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services