Re: [PATCH] Slight improvement of worker_spi.c example

Поиск
Список
Период
Сортировка
От Aleksander Alekseev
Тема Re: [PATCH] Slight improvement of worker_spi.c example
Дата
Msg-id CAJ7c6TOaX8wf60DVozm=cLLLFoLX1O7rM8fiHdURq1+FV1NDWw@mail.gmail.com
обсуждение исходный текст
Ответ на [PATCH] Slight improvement of worker_spi.c example  (Aleksander Alekseev <aleksander@timescale.com>)
Ответы Re: [PATCH] Slight improvement of worker_spi.c example  (Julien Rouhaud <rjuju123@gmail.com>)
Список pgsql-hackers
Hi,

> The patch changes the order to:
>
>     StartTransactionCommand();
>     PushActiveSnapshot(...);
>     SPI_connect();
>
>     ...
>
>     SPI_finish();
>     PopActiveSnapshot();
>     CommitTransactionCommand();
>
> ... and also clarifies that the order of PushActiveSnapshot(...) and
> SPI_connect() is not important.

Additionally I noticed that the check:

```
        if (!process_shared_preload_libraries_in_progress)
                return;
```

... was misplaced in _PG_init(). Here is the patch v2 which fixes this too.

--
Best regards,
Aleksander Alekseev

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Ranier Vilela
Дата:
Сообщение: Avoid unused value (src/fe_utils/print.c)
Следующее
От: Julien Rouhaud
Дата:
Сообщение: Re: [PATCH] Slight improvement of worker_spi.c example