Hi Kuroda-San, here are some review comment for patch v19-00001
======
doc/src/sgml/ref/alter_subscription.sgml
The previous patches have common failover/two_phase code checking for
"Do not allow changing the option if the subscription is enabled", but
it seems the docs were mentioning that only for "two_phase" and not
for "failover".
I'm not 100% sure if mentioning about disabled was necessary, but
certainly it should be all-or-nothing, not just saying it for one of
the parameters. Anyway, I chose to add the missing info. Please see
the attached nitpicks diff.
======
Kind Regards,
Peter Smith.
Fujitsu Australia.