On Wed, Jan 5, 2022 at 4:56 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
>
...
> > > 4.
> > > +#define IDX_PUBACTION_n 3
> > > + ExprState *exprstate[IDX_PUBACTION_n]; /* ExprState array for row filter.
> > > + One per publication action. */
> > > ..
> > > ..
> > >
> > > I think we can have this define outside the structure. I don't like
> > > this define name, can we name it NUM_ROWFILTER_TYPES or something like
> > > that?
> > >
> >
> > Partly fixed in v51* [1], I've changed the #define name but I did not
> > move it. The adjacent comment talks about these ExprState caches and
> > explains the reason why the number is 3. So if I move the #define then
> > half that comment would have to move with it. I thought it is better
> > to keep all the related parts grouped together with the one
> > explanatory comment, but if you still want the #define moved please
> > confirm and I can do it in a future version.
> >
>
> Yeah, I would prefer it to be moved. You can move the part of the
> comment suggesting three pubactions can be used for row filtering.
>
Fixed in v59* [1]
------
[1] https://www.postgresql.org/message-id/CAHut%2BPsiw9fbOUTpCMWirut1ZD5hbWk8_U9tZya4mG-YK%2Bfq8g%40mail.gmail.com
Kind Regards,
Peter Smith.
Fujitsu Australia