On Wed, Sep 21, 2022 at 3:23 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
>
...
> Can't we use the existing function ReplicationOriginNameForTablesync()
> by passing relid as InvalidOid for this purpose? We need a check
> inside to decide which name to construct, otherwise, it should be
> fine. If we agree with this, then we can change the name of the
> function to something like ReplicationOriginNameForLogicalRep or
> ReplicationOriginNameForLogicalRepWorkers.
>
This suggestion attaches special meaning to the reild param.
Won't it seem a bit strange for the non-tablesync callers (who
probably have a perfectly valid 'relid') to have to pass an InvalidOid
relid just so they can format the correct origin name?
------
Kind Regards,
Peter Smith.
Fujitsu Australia